Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set heatmap stencil mode #6807

Merged
merged 1 commit into from
Jun 13, 2018
Merged

Explicitly set heatmap stencil mode #6807

merged 1 commit into from
Jun 13, 2018

Conversation

lbud
Copy link
Contributor

@lbud lbud commented Jun 12, 2018

Fixes #6806. We had not been setting the stencil mode explicitly in the heatmap texture copy pass, meaning it inherited the stencil mode from whatever the previous layer was — presumably heatmaps have been most used immediately above symbol layers (which disable stencil testing) but when they follow a stencil-enabled layer (e.g. fill layers) they inherit a single (most recently used) tile mask from that layer.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • @mourner how did you generate the alternate images for heatmap render tests? Or I suppose I could also just set a higher diff threshold here, since failing tests look very different: …?
    badheat

@lbud lbud changed the title Explicitly set stencil mode (disabled) in heatmap texture copy Explicitly set heatmap stencil mode Jun 12, 2018
@mourner
Copy link
Member

mourner commented Jun 13, 2018

how did you generate the alternate images for heatmap render tests? Or I suppose I could also just set a higher diff threshold here, since failing tests look very different: …?

@lbud hmm, not sure I follow... Alternate images?

@lbud
Copy link
Contributor Author

lbud commented Jun 13, 2018

@mourner it looks like many of the heatmap tests have two possible expected images depending on whether the platform supports half-float-textures-based rendering as of d61850a — is that something I need to worry about/should expect to be an issue for some gl-native platforms when this is ported?

@mourner
Copy link
Member

mourner commented Jun 13, 2018 •
edited
Loading

@lbud the non-half-float versions were generated with GL JS render tests because headless gl doesn't support the half-float extension, and the half-float versions were generated with GL Native render tests locally. Ideally there would be two versions for every test that has heatmaps, but a higher diff is probably OK too.

@lbud lbud changed the base branch from master to release-chai June 13, 2018 17:57
@lbud lbud changed the base branch from release-chai to master June 13, 2018 18:02
@lbud lbud merged commit 7d079a7 into master Jun 13, 2018
@lbud lbud deleted the 6806-heatmap-stencil branch June 13, 2018 18:03
This was referenced Jun 13, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lbud @mourner